Skip to content

Upgrading PowerSystemUtils dependency #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 27, 2022
Merged

Upgrading PowerSystemUtils dependency #599

merged 7 commits into from
May 27, 2022

Conversation

sebastian-peter
Copy link
Member

Resolves #595

@sebastian-peter sebastian-peter changed the title Upgrading PowerSystemUtils dependency & adaptations Upgrading PowerSystemUtils dependency May 24, 2022
sonatype-lift[bot]
sonatype-lift bot reviewed May 24, 2022
View reviewed changes
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@codecov
Copy link

codecov bot commented May 24, 2022 •
edited
Loading

Codecov Report

Merging #599 (d89dd39) into dev (71a8870) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #599      +/-   ##
============================================
- Coverage     77.96%   77.93%   -0.03%     
+ Complexity     2155     2150       -5     
============================================
  Files           275      275              
  Lines          8505     8503       -2     
  Branches        807      807              
============================================
- Hits           6631     6627       -4     
- Misses         1478     1483       +5     
+ Partials        396      393       -3
Impacted Files Coverage Δ
...e3/datamodel/models/input/connector/LineInput.java 75.43% <0.00%> (-1.76%) ⬇️
.../models/input/thermal/CylindricalStorageInput.java 86.66% <0.00%> (-1.67%) ⬇️
...del/utils/validation/ConnectorValidationUtils.java 87.50% <0.00%> (-0.08%) ⬇️
...java/edu/ie3/datamodel/models/input/NodeInput.java 96.49% <0.00%> (-0.07%) ⬇️
...atamodel/models/input/system/type/EvTypeInput.java 77.77% <0.00%> (ø)
...tamodel/models/input/system/type/WecTypeInput.java 72.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a920aa9...d89dd39. Read the comment docs.

@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug0 Bugs
  • Vulnerability0 Vulnerabilities
  • Code Smell0 Code Smells

Coverage and Duplications

  • 60 percent coverage83.33% Coverage (77.10% Estimated after merge)
  • 3 percent duplication0.00% Duplicated Code (0.60% Estimated after merge)

Project ID: edu.ie3:PowerSystemDataModel

View in SonarQube

@t-ober t-ober merged commit aaa11bd into dev May 27, 2022
@t-ober t-ober deleted the sp/#595-adapt-to-PSU-snapshot branch May 27, 2022 07:20
@sebastian-peter sebastian-peter added this to the Version 3.0 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

@t-ober t-ober t-ober approved these changes

@danielfeismann danielfeismann Awaiting requested review from danielfeismann danielfeismann is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

Adapt to changes in PSU snapshot
2 participants
@sebastian-peter @t-ober